linux-kernel - RE: [PATCH V10 5/6] mm: cleancache: update to match akpm frontswap feedback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a2c1697-9ed6-4cb8-8da9-d252045b8a75@default>
Date:	Wed, 28 Sep 2011 07:03:52 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org, jeremy@...p.org,
	hughd@...gle.com, ngupta@...are.org,
	Konrad Wilk <konrad.wilk@...cle.com>, JBeulich@...ell.com,
	Kurt Hackel <kurt.hackel@...cle.com>, npiggin@...nel.dk,
	akpm@...ux-foundation.org, riel@...hat.com, hannes@...xchg.org,
	matthew@....cx, Chris Mason <chris.mason@...cle.com>,
	sjenning@...ux.vnet.ibm.com, jackdachef@...il.com,
	cyclonusj@...il.com, levinsasha928@...il.com
Subject: RE: [PATCH V10 5/6] mm: cleancache: update to match akpm frontswap
 feedback

> From: KAMEZAWA Hiroyuki [mailto:kamezawa.hiroyu@...fujitsu.com]
> Subject: Re: [PATCH V10 5/6] mm: cleancache: update to match akpm frontswap feedback
> 
> On Thu, 15 Sep 2011 14:34:46 -0700
> Dan Magenheimer <dan.magenheimer@...cle.com> wrote:
> 
> > From: Dan Magenheimer <dan.magenheimer@...cle.com>
> > Subject: [PATCH V10 5/6] mm: cleancache: update to match akpm frontswap feedback
> 	err = sysfs_create_group(mm_kobj, &cleancache_attr_group);
> > -#endif /* CONFIG_SYSFS */
> > +#ifdef CONFIG_DEBUG_FS
> > +	struct dentry *root = debugfs_create_dir("cleancache", NULL);
> > +	if (root == NULL)
> > +		return -ENXIO;
> > +	debugfs_create_u64("succ_gets", S_IRUGO, root, &cleancache_succ_gets);
> > +	debugfs_create_u64("failed_gets", S_IRUGO,
> > +				root, &cleancache_failed_gets);
> > +	debugfs_create_u64("puts", S_IRUGO, root, &cleancache_puts);
> > +	debugfs_create_u64("invalidates", S_IRUGO,
> > +				root, &cleancache_invalidates);
> > +#endif

Hi Kame --

Thanks for the review!

> No exisiting userlands are affected by this change of flush->invalidates ?

Not that I'm aware of.  As required by Andrew Morton, the frontswap
patchset now exposes ALL statistics through debugfs instead of sysfs.
For consistency, all cleancache statistics are also moved from sysfs
into debugfs, so this is a good time to also do the name change.
(The name change was also required by Andrew Morton, and previously
suggested by Minchan Kim.)

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/