linux-kernel - Re: [PATCH] udf: enable error print in udf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9zz8398+Mt4yi_etsKr40vHJ6mxb5psd6ix1Ou_dHPOQ@mail.gmail.com>
Date:	Wed, 28 Sep 2011 10:08:54 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udf: enable error print in udf_read_tagged().

2011/9/28 Joe Perches <joe@...ches.com>:
> On Wed, 2011-09-28 at 00:46 +0900, Namjae Jeon wrote:
>> While reading metadata, if a problem occurs, Print out only one of the five case.(It also does not show a checksum properly.)
> []
>> diff --git a/fs/udf/misc.c b/fs/udf/misc.c
> []
>> @@ -211,7 +212,7 @@ struct buffer_head *udf_read_tagged(struct super_block *sb, uint32_t block,
>>
>>       bh = udf_tread(sb, block);
>>       if (!bh) {
>> -             udf_debug("block=%d, location=%d: read failed\n",
>> +             printk(KERN_ERR "block=%d, location=%d: read failed\n",
>
> The other printk in this module uses a "udf: " prefix.
>
> I suggest that
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> is added before any include and these
> conversions use pr_err() instead.
It is good suggestion. I will try to make patch v2 included your suggestion.
Thanks for your review.
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/