linux-kernel - RE: [Open-FCoE] [PATCH] drivers/firmware/edd: Treat "XPRS" host bus type the same as "PCI"

Open Source and information security mailing list archives

Message-ID: <5A9BD224CEA58D4CB62235967D650C160EB7A807@orsmsx509.amr.corp.intel.com>
Date:	Tue, 27 Sep 2011 21:34:08 -0700
From:	"Zou, Yi" <yi.zou@...el.com>
To:	Michael Chan <mchan@...adcom.com>,
	"Matt_Domsch@...l.com" <Matt_Domsch@...l.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"devel@...n-fcoe.org" <devel@...n-fcoe.org>
Subject: RE: [Open-FCoE] [PATCH] drivers/firmware/edd: Treat "XPRS" host bus
 type the same as "PCI"

> 
> PCI Express devices will return "XPRS" host bus type during BIOS EDD
> call.  "XPRS" should be treated just like "PCI" so that the proper
> pci_dev symlink will be created.  Scripts such as fcoe-edd.sh will
> then work correctly.
> 
> Cc: Matt Domsch <Matt_Domsch@...l.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Patch looks good to me. Just a minor note, not to be picky, the script
you mentioned is actually called 'fcoe_edd.sh', not '-'.

Reviewed-by: Yi Zou <yi.zou@...el.com>

> ---
>  drivers/firmware/edd.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
> index f1b7f65..e229576 100644
> --- a/drivers/firmware/edd.c
> +++ b/drivers/firmware/edd.c
> @@ -151,7 +151,8 @@ edd_show_host_bus(struct edd_device *edev, char *buf)
>  		p += scnprintf(p, left, "\tbase_address: %x\n",
>  			     info->params.interface_path.isa.base_address);
>  	} else if (!strncmp(info->params.host_bus_type, "PCIX", 4) ||
> -		   !strncmp(info->params.host_bus_type, "PCI", 3)) {
> +		   !strncmp(info->params.host_bus_type, "PCI", 3) ||
> +		   !strncmp(info->params.host_bus_type, "XPRS", 4)) {
>  		p += scnprintf(p, left,
>  			     "\t%02x:%02x.%d  channel: %u\n",
>  			     info->params.interface_path.pci.bus,
> @@ -159,7 +160,6 @@ edd_show_host_bus(struct edd_device *edev, char *buf)
>  			     info->params.interface_path.pci.function,
>  			     info->params.interface_path.pci.channel);
>  	} else if (!strncmp(info->params.host_bus_type, "IBND", 4) ||
> -		   !strncmp(info->params.host_bus_type, "XPRS", 4) ||
>  		   !strncmp(info->params.host_bus_type, "HTPT", 4)) {
>  		p += scnprintf(p, left,
>  			     "\tTBD: %llx\n",
> @@ -668,7 +668,7 @@ edd_get_pci_dev(struct edd_device *edev)
>  {
>  	struct edd_info *info = edd_dev_get_info(edev);
> 
> -	if (edd_dev_is_type(edev, "PCI")) {
> +	if (edd_dev_is_type(edev, "PCI") || edd_dev_is_type(edev, "XPRS"))
> {
>  		return pci_get_bus_and_slot(info-
> >params.interface_path.pci.bus,
>  				     PCI_DEVFN(info-
> >params.interface_path.pci.slot,
>  					       info->params.interface_path.pci.
> --
> 1.7.1.GIT
> 
> 
> _______________________________________________
> devel mailing list
> devel@...n-fcoe.org
> https://lists.open-fcoe.org/mailman/listinfo/devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives