linux-kernel - Re: [PATCH 1/2] leds-class: change back LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110929080753.GC23944@n2100.arm.linux.org.uk>
Date:	Thu, 29 Sep 2011 09:07:53 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Richard Purdie <richard.purdie@...uxfoundation.org>
Cc:	Bryan Wu <bryan.wu@...onical.com>, linux-kernel@...r.kernel.org,
	linus.walleij@...aro.org, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate
	instead of bool

On Mon, Sep 05, 2011 at 08:51:38PM +0100, Richard Purdie wrote:
> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
> > LEDS_CLASS is required by leds and trigger drivers, but we can build it
> > as module. So change this option back as tristate and treak the help
> > message as well.
> > 
> > Signed-off-by: Bryan Wu <bryan.wu@...onical.com>
> 
> Acked-by: Richard Purdie <rchard.purdie@...uxfoundation.org>
> 
> > ---
> >  drivers/leds/Kconfig |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index b591e72..1c35927 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
> >  if NEW_LEDS
> >  
> >  config LEDS_CLASS
> > -	bool "LED Class Support"
> > +	tristate "LED Class Support"
> >  	help
> >  	  This option enables the led sysfs class in /sys/class/leds.  You'll
> > -	  need this to do anything useful with LEDs.  If unsure, say N.
> > +	  need this to do anything useful with LEDs.  If unsure, say M.
> > +
> > +	  Note: don't disable it as N, because plenty of led and trigger drivers
> > +	  are using this option.

This is crap - putting a dependency in the help for an option is
unacceptable when we have things like randconfig etc which are
expected to work.

If this must be 'm' or 'y', then make it depend on m to force the
minimum setting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/