linux-kernel - Re: [patch 06/11] mm: memcg: remove optimization of keeping the root_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110929092033.GB6050@redhat.com>
Date:	Thu, 29 Sep 2011 11:20:33 +0200
From:	Johannes Weiner <jweiner@...hat.com>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Balbir Singh <bsingharora@...il.com>,
	Ying Han <yinghan@...gle.com>,
	Greg Thelen <gthelen@...gle.com>,
	Michel Lespinasse <walken@...gle.com>,
	Rik van Riel <riel@...hat.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Christoph Hellwig <hch@...radead.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 06/11] mm: memcg: remove optimization of keeping the
 root_mem_cgroup LRU lists empty

On Tue, Sep 20, 2011 at 05:02:29PM +0200, Michal Hocko wrote:
> On Mon 12-09-11 12:57:23, Johannes Weiner wrote:
> > root_mem_cgroup, lacking a configurable limit, was never subject to
> > limit reclaim, so the pages charged to it could be kept off its LRU
> > lists.  They would be found on the global per-zone LRU lists upon
> > physical memory pressure and it made sense to avoid uselessly linking
> > them to both lists.
> > 
> > The global per-zone LRU lists are about to go away on memcg-enabled
> > kernels, with all pages being exclusively linked to their respective
> > per-memcg LRU lists.  As a result, pages of the root_mem_cgroup must
> > also be linked to its LRU lists again.
> 
> Nevertheless we still do not charge them so this should be mentioned
> here?

Added for the next revision:

	"This is purely about the LRU list, root_mem_cgroup is still
	not charged."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/