linux-kernel - Re: [PATCH 2/4] kmemleak: Handle percpu memory allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317297373.2855.11.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Thu, 29 Sep 2011 13:56:13 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	linux-kernel@...r.kernel.org, Huajun Li <huajun.li.lee@...il.com>,
	Tejun Heo <tj@...nel.org>,
	Christoph Lameter <cl@...ux-foundation.org>
Subject: Re: [PATCH 2/4] kmemleak: Handle percpu memory allocation

Le jeudi 29 septembre 2011 à 12:02 +0100, Catalin Marinas a écrit :
> This patch adds kmemleak callbacks from the percpu allocator, reducing a
> number of false positives caused by kmemleak not scanning such memory
> blocks. The percpu chunks are never reported as leaks because of current
> kmemleak limitations with the __percpu pointer not pointing directly to
> the actual chunks.
> 
> Reported-by: Huajun Li <huajun.li.lee@...il.com>
> Cc: Tejun Heo <tj@...nel.org>,
> Cc: Christoph Lameter <cl@...ux-foundation.org>
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> ---

Hi Catalin

I wonder if you tried it on a 16 or 64 cpus machine ?

I guess we should increase CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE default

Or you could add new kmemleak_percpu_alloc() / kmemleak_percpu_free()
primitives to not waste entries in early_log[]



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/