linux-kernel - Re: [PATCHv2] fat: don't use custom hex_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ipob8l4l.fsf@devron.myhome.or.jp>
Date:	Thu, 29 Sep 2011 23:43:22 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-kernel@...r.kernel.org,
	Denys Vlasenko <vda.linux@...glemail.com>
Subject: Re: [PATCHv2] fat: don't use custom hex_to_bin()

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

>> So, I think it should be something like
>> 
>> 	u8 uc[2];
>> 	if (hex2bin(uc, ip + 1, 2) < 0)
>>         	return -EINVAL;
>> 	*(wchar_t *)op = uc[0] << 8 | uc[1];
>> This should be readable more.
> It might be so, but it's not okay to do such constructions in C
>
> fs/fat/namei_vfat.c:535:1: warning: ISO C90 forbids mixed declarations
> and code [-Wdeclaration-after-statement]
>
> So, I will resend patch as I proposed with additional comments.

I guess you just did copy&paste. "u8 uc[2];" part should be before
statement as C90.

I.e.

				if (escape && (*ip == ':')) {
                                	u8 uc[2];

					if (i > len - 5)
						return -EINVAL;

					if (hex2bin(uc, ip + 1, 2) < 0)
						return -EINVAL;
					*(wchar_t *)op = uc[0] << 8 | uc[1];

					op += 2;
					ip += 5;
					i += 5;
				} else {

This should be work?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/