linux-kernel - Re: [PATCHv2] fat: don't use custom hex_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87aa9n8jh0.fsf@devron.myhome.or.jp>
Date:	Fri, 30 Sep 2011 00:19:07 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-kernel@...r.kernel.org,
	Denys Vlasenko <vda.linux@...glemail.com>
Subject: Re: [PATCHv2] fat: don't use custom hex_to_bin()

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

> On Thu, 2011-09-29 at 23:43 +0900, OGAWA Hirofumi wrote: 
>> I guess you just did copy&paste. "u8 uc[2];" part should be before
>> statement as C90.
>> 
>> I.e.
>> 
>> 				if (escape && (*ip == ':')) {
>>                                 	u8 uc[2];
>> 
>> 					if (i > len - 5)
>> 						return -EINVAL;
>> 
>> 					if (hex2bin(uc, ip + 1, 2) < 0)
>> 						return -EINVAL;
>> 					*(wchar_t *)op = uc[0] << 8 | uc[1];
> Actually, why do not use 
> *(wchar_t *)op++ = ... 
> instead of additional op+=2?

IMO, the reason would be, complex oneliner is possible to mistake. Well,
anyway, it doesn't work. It actually increments 1 byte as "char *", not
2 bytes as "wchar_t *".

>> 
>> 					op += 2;
>> 					ip += 5;
>> 					i += 5;
>> 				} else {
>> 
>> This should be work?
> Oh, my bad! So much minor mistakes last time. Really need vacation.

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/