linux-kernel - Re: [PATCH v3] fs/minix: Verify bitmap block counts before mounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110929185132.GM2203@ZenIV.linux.org.uk>
Date:	Thu, 29 Sep 2011 19:51:32 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Josh Boyer <jwboyer@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3] fs/minix: Verify bitmap block counts before mounting

On Thu, Sep 29, 2011 at 02:38:18PM -0400, Josh Boyer wrote:
> On Fri, Aug 19, 2011 at 02:50:25PM -0400, Josh Boyer wrote:
> > Newer versions of MINIX can create filesystems that allocate an extra
> > bitmap block.  Mounting of this succeeds, but doing a statfs call will
> > result in an oops in count_free because of a negative number being used
> > for the bh index.
> > 
> > Avoid this by verifying the number of allocated blocks at mount time,
> > erroring out if there are not enough and make statfs ignore the extras
> > if there are too many.
> > 
> > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=18792
> > 
> > Signed-off-by: Josh Boyer <jwboyer@...hat.com>
> 
> Al, did this ever get queued up to send to Linus?

Sits in my tree, waiting for kernel.org to come back, with obvious
followup on top of it...

commit 2a0b3282ff528af4c0824c16d99c62a53d029720
Author: Al Viro <viro@...iv.linux.org.uk>
Date:   Fri Aug 26 22:38:50 2011 -0400

    minixfs: kill manual hweight(), simplify
    
    Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

commit b928f2ccce51ffd666e4238e8c166dfeb0069c28
Author: Josh Boyer <jwboyer@...hat.com>
Date:   Fri Aug 19 14:50:26 2011 -0400

    fs/minix: Verify bitmap block counts before mounting

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/