linux-kernel - Re: [004/244] sfi: table irq 0xFF means no interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110929185623.GB8183@suse.de>
Date:	Thu, 29 Sep 2011 11:56:23 -0700
From:	Greg KH <gregkh@...e.de>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	stable-review@...nel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [004/244] sfi: table irq 0xFF means no interrupt

On Thu, Sep 29, 2011 at 05:33:46PM +0300, Kirill A. Shutemov wrote:
> On Thu, Sep 29, 2011 at 07:18:27AM -0700, Greg KH wrote:
> > On Thu, Sep 29, 2011 at 01:21:00PM +0300, Kirill A. Shutemov wrote:
> > > On Wed, Sep 28, 2011 at 02:59:28PM -0700, Greg KH wrote:
> > > > 3.0-stable review patch.  If anyone has any objections, please let us know.
> > > > 
> > > > ------------------
> > > > 
> > > > From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> > > > 
> > > > commit a94cc4e6c0a26a7c8f79a432ab2c89534aa674d5 upstream.
> > > > 
> > > > According to the SFI specification irq number 0xFF means device has no
> > > > interrupt or interrupt attached via GPIO.
> > > > 
> > > > Currently, we don't handle this special case and set irq field in
> > > > *_board_info structs to 255.  It leads to confusion in some drivers.
> > > > Accelerometer driver tries to register interrupt 255, fails and prints
> > > > "Cannot get IRQ" to dmesg.
> > > > 
> > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > > > Signed-off-by: Alan Cox <alan@...ux.intel.com>
> > > > Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > > 
> > > Please, take this as well:
> > > 
> > > http://lkml.org/lkml/2011/9/14/40
> > 
> > Is that patch in Linus's tree?
> 
> No, it isn't.
> 
> Do not apply "sfi: table irq 0xFF means no interrupt" in this case. It
> breaks kexec. Better to take both patches into next stable release.

Ok, I've dropped this patch from the release.

Please let me know when you get the fixup patch into Linus's tree, and
let me know that it needs to be added to the 3.0-stable tree, along with
this one.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/