linux-kernel - Re: [PATCH 08/10] iommu/omap: Use bus_set_iommu instead of register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110929200423.GB26760@kroah.com>
Date:	Thu, 29 Sep 2011 13:04:23 -0700
From:	Greg KH <greg@...ah.com>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	iommu@...ts.linux-foundation.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alex Williamson <alex.williamson@...hat.com>,
	Ohad Ben-Cohen <ohad@...ery.com>,
	David Woodhouse <dwmw2@...radead.org>,
	David Brown <davidb@...eaurora.org>, joro@...tes.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] iommu/omap: Use bus_set_iommu instead of
 register_iommu

On Fri, Sep 23, 2011 at 05:45:54PM +0200, Joerg Roedel wrote:
> Convert the OMAP IOMMU driver on ARM to use the new
> interface for publishing the iommu_ops.
> 
> Cc: Ohad Ben-Cohen <ohad@...ery.com>
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> ---
>  drivers/iommu/omap-iommu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index bd5f606..16d5b76 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1250,7 +1250,7 @@ static int __init omap_iommu_init(void)
>  		return -ENOMEM;
>  	iopte_cachep = p;
>  
> -	register_iommu(&omap_iommu_ops);
> +	bus_set_iommu(&platform_bus_type, &omap_iommu_ops);

I too worry about this.

It kind of looks like the omap code should not be using the platform bus
code for this, but instead, use their own bus code, as I'm sure that not
all platform devices really work properly with this iommu controller,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/