linux-kernel - Re: [PATCH] Clean up brlocks/lglocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110929153618.c761d9bb.akpm00@gmail.com>
Date:	Thu, 29 Sep 2011 15:36:18 -0700
From:	Andrew Morton <akpm00@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	viro@...iv.linux.org.uk,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Clean up brlocks/lglocks

On Wed, 28 Sep 2011 16:30:44 -0700
Andi Kleen <andi@...stfloor.org> wrote:

> lglocks and brlocks are currently generated with some complicated macros
> in lglock.h. But there's no reason, I can see, to not just use common
> utility functions that get pointers to the lglock.

https://lkml.org/lkml/2011/8/24/454 makes me suspect that there's a bug
in brlocks, or they're being misused in some way.  However the code
doesn't have an identifiable maintainer, so things just sit there.

I guess these problems don't preclude cosmetic cleanups, but it's all a
bit regrettable.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/