linux-kernel - Re: [PATCH -next] x86 mrst: fix build error when X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Sep 2011 23:57:08 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH -next] x86 mrst: fix build error when X86_MRST is not
 enabled

On Thu, 29 Sep 2011 13:35:16 -0700
Randy Dunlap <rdunlap@...otime.net> wrote:

> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Fix build when CONFIG_X86_INTEL_MID is enabled but
> CONFIG_X86_MRST is not enabled.  Fixes this build error:

This looks wrong. Unfortunately until we get kernel.org back its hard to
do much about it and see what is in all the trees.

> -#ifdef CONFIG_X86_INTEL_MID
> +#ifdef CONFIG_X86_MRST
>  
>  static inline enum mrst_cpu_type mrst_identify_cpu(void)
>  {
>  	return __mrst_cpu_chip;
>  }
>  
> -#else /* !CONFIG_X86_INTEL_MID */
> +#else /* !CONFIG_X86_MRST */
>  
>  #define mrst_identify_cpu()    (0)
>  
> -#endif /* !CONFIG_X86_INTEL_MID */
> +#endif /* !CONFIG_X86_MRST */

This breaks Medfield so NAK

The correct behaviour should be 

INTEL_MID defined -> mrst_cpu_chip has meaning
INTEL_MID not defined -> mrst_identify_chip is 0

your change makes it 0 for Medfield which means it will crash on boot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/