linux-kernel - Re: [PATCH] init:main.c: start 'usermodehelper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzjAinwRcw-xd4U8tR+bDdpf2h2kP=cEd5hw+K6ZPt3QQ@mail.gmail.com>
Date:	Thu, 29 Sep 2011 00:23:07 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	wangyanqing <Udknight@...il.com>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init:main.c: start 'usermodehelper_enable()' a little early

On Thu, Sep 29, 2011 at 12:09 AM, wangyanqing <udknight@...il.com> wrote:
> commit d5767c53535ac79758084773418e0ad186aba4a2 move 'usermodehelper_enable()'
> to end of rest_init, then I get failed to let uvesafb work on my computer, and
> lose the splash boot.So maybe we could start usermodehelper_enable a little early
> to make some task work that need eary init with the help of user mode.

Grr. Initcalls *really* shouldn't depend on usermode helpers.

That said, I'm not entirely shocked if they do. But could you try to
describe *which* initcall it is? The call trace should tell you?

I'm not saying the patch is wrong (and it may be what we have to do at
this point), but I do think it would be even better if we could fix
the real problem of initcalls calling usermode helpers instead...

           Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/