linux-kernel - Re: Workaround for Intel MPS errata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc03678ef8baaa29a8ab3c086ba6bb78.squirrel@webmail.sf-mail.de>
Date:	Fri, 30 Sep 2011 09:03:24 +0200
From:	"Rolf Eike Beer" <eike-kernel@...tec.de>
To:	"Jon Mason" <mason@...i.com>
Cc:	"Avi Kivity" <avi@...hat.com>,
	"Sven Schnelle" <svens@...ckframe.org>,
	"Simon Kirby" <sim@...tway.ca>,
	"Eric Dumazet" <eric.dumazet@...il.com>,
	"Niels Ole Salscheider" <niels_ole@...scheider-online.de>,
	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"Ben Hutchings" <bhutchings@...arflare.com>
Subject: Re: Workaround for Intel MPS errata

> Hey Avi,
> Can you try this patch?  It should resolve the issue you are seeing.
>
> Thanks,
> Jon
>
>     PCI: Workaround for Intel MPS errata
>
>     Intel 5000 and 5100 series memory controllers have a known issue if
> read
>     completion coalescing is enabled (the default setting) and the PCI-E
>     Maximum Payload Size is set to 256B.  To work around this issue,
> disable
>     read completion coalescing if the MPS is 256B.
>
>     http://www.intel.com/content/dam/doc/specification-update/5000-chipset-memory-controller-hub-specification-update.pdf
>     http://www.intel.com/content/dam/doc/specification-update/5100-memory-controller-hub-chipset-specification-update.pdf
>
>     Reported-by: Avi Kivity <avi@...hat.com>
>     Signed-off-by: Jon Mason <mason@...i.com>
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index a919db2..13c733a 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -1361,6 +1361,80 @@ static int pcie_find_smpss(struct pci_dev *dev,
> void *data)
>  	return 0;
>  }
>
> +static void pcie_errata_check(int mps)
> +{

While this whole function is about Intel 5x00 devices the name of it is
very generic (and in a very generic file). Maybe this can be changed, e.g.
"fixup:" renamed to "fixup_intel_5x00:". Also I wonder if that shouldn't
be a nop when CONFIG_PCI_QUIRKS is not set.

Eike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/