linux-kernel - Re: [PATCH -next] x86 mrst: fix build error when X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110930100704.6ea882c8@lxorguk.ukuu.org.uk>
Date:	Fri, 30 Sep 2011 10:07:04 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrew Morton <akpm00@...il.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH -next] x86 mrst: fix build error when X86_MRST is not
 enabled

> > This breaks Medfield so NAK
> > 
> > The correct behaviour should be 
> > 
> > INTEL_MID defined -> mrst_cpu_chip has meaning
> > INTEL_MID not defined -> mrst_identify_chip is 0
> > 
> > your change makes it 0 for Medfield which means it will crash on boot.
> 
> Randy's patch is an attempt to fix Mathias's "x86: rtc: don't register
> a platform RTC device for Intel MID platforms".

NAK this.

> I'm tempted to do a mass droppage, but then some of the patches might
> get forever lost.

Randy's patch breaks Medfield, simply because he's seeing an incomplete
set of merges. The stuff the x86 maintainers were sent already deals with
this. It's all simply a case of waiting for the trees to get back into
sync, at which point platform/x86/mrst will get built for INTEL_MID
general case.

> Could we please get some x86 maintainers on deck??

Well currently x86@...nel.org is undeliverable so that won't help you.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/