linux-kernel - Re: [PATCH] man ptrace: add extended description of various ptrace quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK1hOcPqVYY93VFbDbMZ39iCr7VH+hP-bQT3u0SPJXmezN7H3Q@mail.gmail.com>
Date:	Fri, 30 Sep 2011 16:28:23 +0200
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	mtk.manpages@...il.com
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Jan Kratochvil <jan.kratochvil@...hat.com>,
	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	linux-man <linux-man@...r.kernel.org>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Chuck Ebbert <76306.1226@...puserve.com>,
	Blaisorblade <blaisorblade@...oo.it>,
	Daniel Jacobowitz <dan@...ian.org>
Subject: Re: [PATCH] man ptrace: add extended description of various ptrace quirks

On Thu, Sep 29, 2011 at 9:08 PM, Michael Kerrisk <mtk.manpages@...il.com> wrote:
> So, I took your patch, and then did a global edit of the page to fix
> various pieces (in the existing text, as well as do some language
> clean-ups for the new text). In the process, I found a number of
> pieces that are still unclear (some in the old text, some in your new
> text). I also made some changes to your text that I'd like you to
> check. I've marked each of these with FIXME below. Could you please
> take a look at the FIXMEs, and write me a comment for each of these.
> (I appreciate that in some cases, especially for the existing text,
> you may not have a handy answer Denys, but if you (and others) can
> give any help, that would be great.)
>
> Rather than you writing a new patch to this version of the page, I
> think it might be easiest if you just replied to the FIXMEs inline
> below, then I can revise the page in the light of your comments.

       Another group of commands makes the ptrace-stopped  tracee  run.   They
       have the form:

           ptrace(PTRACE_cmd, pid, 0, sig);

       where  cmd  is  PTRACE_CONT, PTRACE_DETACH, PTRACE_SYSCALL, PTRACE_SIN-
       GLESTEP, PTRACE_SYSEMU, or PTRACE_SYSEMU_SINGLESTEP.

Cosmetics: cmd is, of course, CONT, DETACH,..., not PTRACE_CONT,
PTRACE_DETACH...


       If the tracee  is
       in  signal-delivery-stop,  sig  is  the signal to be injected (if it is
       nonzero).  Otherwise, sig may be ignored.  (Recommended practice is  to
       always pass 0 in these cases.)

Looks like (my) text in last sentence is confusing. I meant:
"If you are resterting thracee from a ptrace-stop other than
signal-delivery-stop, recommended practice is  to always pass
sig == 0".

-- 
vda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/