linux-kernel - Re: [PATCH 02/11] virtio-pci: add PM notification handlers for restore, freeze, thaw, poweroff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110930030659.GA25524@amit-x200.redhat.com>
Date:	Fri, 30 Sep 2011 08:36:59 +0530
From:	Amit Shah <amit.shah@...hat.com>
To:	Sasha Levin <levinsasha928@...il.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 02/11] virtio-pci: add PM notification handlers for
 restore, freeze, thaw, poweroff

On (Thu) 29 Sep 2011 [21:36:38], Sasha Levin wrote:
> 
> After drv->freeze() completes, the vq is freed from guest memory, but is
> there anything that prevents from the device to keep writing into that
> vq?
> 
> Shouldn't we set status to '0' before we free vqs?

Yes, this should be done in the driver code though, not in common
code.  I've fixed this in my tree.

Thanks,

		Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/