linux-kernel - Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110930021239.GL12606@ponder.secretlab.ca>
Date:	Thu, 29 Sep 2011 20:12:39 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Stephen Warren <swarren@...dia.com>,
	Barry Song <21cnbao@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Joe Perches <joe@...ches.com>,
	Russell King <linux@....linux.org.uk>,
	Linaro Dev <linaro-dev@...ts.linaro.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	David Brown <davidb@...eaurora.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 2/2 v7] pinmux: add a driver for the U300 pinmux

On Fri, Sep 16, 2011 at 02:14:09PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@...aro.org>
> 
> This adds a driver for the U300 pinmux portions of the system
> controller "SYSCON". It also serves as an example of how to use
> the pinmux subsystem. This driver also houses the platform data
> for the only supported platform.

Hi Linus, comments below.

> diff --git a/arch/arm/mach-u300/Kconfig b/arch/arm/mach-u300/Kconfig
> index 32a7b0f..449fd6a 100644
> --- a/arch/arm/mach-u300/Kconfig
> +++ b/arch/arm/mach-u300/Kconfig
> @@ -6,6 +6,8 @@ comment "ST-Ericsson Mobile Platform Products"
>  
>  config MACH_U300
>  	bool "U300"
> +	select PINCTRL
> +	select PINMUX_U300

Shouldn't PINMUX_U300 select PINCTRL?

> +#include "pinmux-u300.h"

There is only one file that uses this header data.  Just put it into
the .c file.

> +static int __init u300_pmx_probe(struct platform_device *pdev)
> +{
> +	int ret;
> +	struct u300_pmx *upmx;
> +	struct resource *res;
> +
> +	/* Create state holders etc for this driver */
> +	upmx = kzalloc(sizeof(struct u300_pmx), GFP_KERNEL);

devm_kzalloc()

> +	if (!upmx)
> +		return -ENOMEM;
> +
> +	upmx->dev = &pdev->dev;
> +
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res) {
> +		ret = -ENOENT;
> +		goto out_no_resource;
> +	}
> +	upmx->phybase = res->start;
> +	upmx->physize = resource_size(res);
> +
> +	if (request_mem_region(upmx->phybase, upmx->physize,
> +			       DRIVER_NAME) == NULL) {
> +		ret = -EBUSY;
> +		goto out_no_memregion;
> +	}
> +
> +	upmx->virtbase = ioremap(upmx->phybase, upmx->physize);
> +	if (!upmx->virtbase) {
> +		ret = -ENOMEM;
> +		goto out_no_remap;
> +	}
> +
> +	upmx->pctl = pinctrl_register(&u300_pmx_desc, &pdev->dev, upmx);
> +	if (IS_ERR(upmx->pctl)) {
> +		dev_err(&pdev->dev, "could not register U300 pinmux driver\n");
> +		ret = PTR_ERR(upmx->pctl);
> +		goto out_no_pmx;
> +	}
> +
> +	/* We will handle a range of GPIO pins */
> +	pinctrl_add_gpio_range(upmx->pctl, &u300_gpio_range);
> +
> +	platform_set_drvdata(pdev, upmx);
> +
> +	u300_pmx_dumpregs(upmx);
> +
> +	dev_info(&pdev->dev, "initialized U300 pinmux driver\n");
> +
> +	return 0;
> +
> +out_no_pmx:
> +	iounmap(upmx->virtbase);
> +out_no_remap:
> +	platform_set_drvdata(pdev, NULL);
> +out_no_memregion:
> +	release_mem_region(upmx->phybase, upmx->physize);
> +out_no_resource:
> +	kfree(upmx);
> +	return ret;
> +}
> +
> +static int __exit u300_pmx_remove(struct platform_device *pdev)

__devexit

> +{
> +	struct u300_pmx *upmx = platform_get_drvdata(pdev);
> +
> +	pinctrl_remove_gpio_range(upmx->pctl, &u300_gpio_range);
> +	pinctrl_unregister(upmx->pctl);
> +	iounmap(upmx->virtbase);
> +	release_mem_region(upmx->phybase, upmx->physize);
> +	platform_set_drvdata(pdev, NULL);
> +	kfree(upmx);
> +
> +	return 0;
> +}
> +
> +static struct platform_driver u300_pmx_driver = {
> +	.driver = {
> +		.name = DRIVER_NAME,
> +		.owner = THIS_MODULE,
> +	},
> +	.remove = __exit_p(u300_pmx_remove),

__devexit_p

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/