linux-kernel - Re: [PATCH 7/8] staging: et131x: Updating copyright statements and module authors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANK3SE3g0Abt-Lr6AE2e0vsVQVx-Y2d_SZyLi+Uo0N0q+=HHdQ@mail.gmail.com>
Date:	Sun, 2 Oct 2011 19:54:09 +0100
From:	Mark Einon <mark.einon@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org, o.hartmann@...ovital.com
Subject: Re: [PATCH 7/8] staging: et131x: Updating copyright statements and
 module authors

On 1 October 2011 20:58, Dan Carpenter <dan.carpenter@...cle.com>
wrote:> On Sat, Oct 01, 2011 at 11:14:16AM +0100, Mark Einon wrote:>>
@@ -945,5 +947,6 @@ module_exit(et131x_cleanup_module);>>>>  /*
Modinfo parameters (filled out using defines from et131x_version.h)
*/>>  MODULE_AUTHOR(DRIVER_AUTHOR);>>
+MODULE_AUTHOR(DRIVER_AUTHOR2);>>  MODULE_DESCRIPTION(DRIVER_INFO);>>
MODULE_LICENSE(DRIVER_LICENSE);>> Both DRIVER_AUTHOR and
DRIVER_AUTHOR2 are silly macros.  Put the name> in directly.  That way
you won't need the comment explaining where to> find the definitions.
Also normally people use gt lt brackets for> emails:>>
MODULE_AUTHOR("Victor Soriano <vjsoriano@...re.com>");>
MODULE_AUTHOR("Mark Einon <mark.einon@...il.com>");>> Go ahead and fix
this in a later patch if you want.  All the macros> there should
probably be replaced.
Hi Dan, thanks for the feedback.Removing et131x_version.h file and
simplifying the macros is alreadyon my todo list.
>> Btw, the problems with kernel.org have complicated things here, so> I can't tell if you have already fixed this, but the driver doesn't> compile any more.  The Kconfig file says it "depends on NETDEV_1000"> but NETDEV_1000 isn't around any more since f860b0522f65d3> "drivers/net: Kconfig and Makefile cleanup" was merged.>
No, I've not experienced this issue yet. I'm using Greg's
staging-2.6tree, last updated at 7cbf3c7cd59 which doesn't have the
commit youmention.I'll look out for it when everything gets moving
again.
Cheers,
Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/