linux-kernel - Re: [PATCH] exofs/super.c: local functions should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E897F4E.5010703@panasas.com>
Date:	Mon, 3 Oct 2011 11:24:30 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	<osd-dev@...n-osd.org>, <bhalevy@...asas.com>
Subject: Re: [PATCH] exofs/super.c: local functions should be static

On 09/23/2011 11:46 PM, H Hartley Sweeten wrote:
> This quiets the following sparse noise:
> 
> warning: symbol 'exofs_sync_fs' was not declared. Should it be static?
> warning: symbol 'exofs_free_sbi' was not declared. Should it be static?
> warning: symbol 'exofs_get_parent' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Boaz Harrosh <bharrosh@...asas.com>
> Cc: Benny Halevy <bhalevy@...asas.com>
> 

Both patches are in linux-next for the next merge window

Thanks Hartley
Boaz

> ---
> 
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 9049e27..8c900d4 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -356,7 +356,7 @@ static const struct export_operations exofs_export_ops;
>  /*
>   * Write the superblock to the OSD
>   */
> -int exofs_sync_fs(struct super_block *sb, int wait)
> +static int exofs_sync_fs(struct super_block *sb, int wait)
>  {
>  	struct exofs_sb_info *sbi;
>  	struct exofs_fscb *fscb;
> @@ -430,7 +430,7 @@ static void _exofs_print_device(const char *msg, const char *dev_path,
>  		msg, dev_path ?: "", odi->osdname, _LLU(pid));
>  }
>  
> -void exofs_free_sbi(struct exofs_sb_info *sbi)
> +static void exofs_free_sbi(struct exofs_sb_info *sbi)
>  {
>  	while (sbi->comps.numdevs) {
>  		int i = --sbi->comps.numdevs;
> @@ -969,7 +969,7 @@ static const struct super_operations exofs_sops = {
>   * EXPORT OPERATIONS
>   *****************************************************************************/
>  
> -struct dentry *exofs_get_parent(struct dentry *child)
> +static struct dentry *exofs_get_parent(struct dentry *child)
>  {
>  	unsigned long ino = exofs_parent_ino(child);
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/