linux-kernel - Re: [PATCH 1/2 v2] udf : enable error print in udf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd9HMPQYiab7r5jjKoMyxArrfkoF74zBfwdBndA5PYQO6A@mail.gmail.com>
Date:	Mon, 3 Oct 2011 22:58:54 +0900
From:	NamJae Jeon <linkinjeon@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 v2] udf : enable error print in udf_read_tagged().

2011/10/3 Joe Perches <joe@...ches.com>:
> On Mon, 2011-10-03 at 16:19 +0900, Namjae Jeon wrote:
>> And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also.
> []
>> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
> []
>> @@ -19,18 +21,15 @@
>>  #undef UDFFS_DEBUG
>>
>>  #ifdef UDFFS_DEBUG
>> -#define udf_debug(f, a...) \
>> -do { \
>> -     printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
>> -             __FILE__, __LINE__, __func__); \
>> -     printk(f, ##a); \
>> -} while (0)
>> +#define udf_debug(fmt, ...)  \
>> +     pr_debug("DEBUG %s:%d:%s: ", fmt,       \
>> +             __FILE__, __LINE__, __func__, __VA_ARGS__);
>
> This doesn't compile properly if UDFFS_DEBUG is
> #defined.
>
> No comma should be between "DEBUG %s:%d:%s: " and fmt.
Hi. Joe.
oops! it's my mistake.
I  sent v3 patch again.
Would you review one more ?
Thanks.
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/