[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111003143553.GG23811@sirena.org.uk>
Date: Mon, 3 Oct 2011 15:35:53 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@....linux.org.uk>
Cc: alsa-devel@...a-project.org, Arnd Bergmann <arnd@...db.de>,
Dmitry Artamonow <mad_soft@...ox.ru>,
linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [alsa-devel] [PATCH 2/6] ASoC: codecs: AK4641 depends on
GPIOLIB
On Mon, Oct 03, 2011 at 02:45:27PM +0100, Russell King - ARM Linux wrote:
> On Sun, Oct 02, 2011 at 09:41:07PM +0100, Mark Brown wrote:
> > No, gpiolib is one implementation of the GPIO API but if platforms want
> > to go and define their own that's currently OK (personally I think at
> > this point we should just be converting all the stragglers over to
> > gpiolib). As things stand we shouldn't have dependencies on a
> > particular implementation of the API.
> Then it should depend on GENERIC_GPIO (not to be confused with GPIO_GENERIC,
> the generic gpiolib driver), which is the symbol meaning that the GPIO API
> is provided by something.
Not for devices like this where the GPIOs are an optional thing the
driver can use, a dependency is far too strong. Devices like that
should be able to rely on the stubs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists