linux-kernel - RE: [PATCH v2 0/3] staging: zcache: xcfmalloc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317657556.16137.696.camel@nimitz>
Date:	Mon, 03 Oct 2011 08:59:16 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	Nitin Gupta <ngupta@...are.org>, Greg KH <greg@...ah.com>,
	gregkh@...e.de, devel@...verdev.osuosl.org,
	cascardo@...oscopio.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, brking@...ux.vnet.ibm.com,
	rcj@...ux.vnet.ibm.com
Subject: RE: [PATCH v2 0/3] staging: zcache: xcfmalloc support

Hi Dan/Nitin,

I've been reading through Seth's patches a bit and looking over the
locking in general.  I'm wondering why preempt_disable() is used so
heavily.  Preempt seems to be disabled for virtually all of zcache's
operations.  It seems a bit unorthodox, and I guess I'm anticipating the
future screams of the low-latency folks. :)

I think long-term it will hurt zcache's ability to move in to other
code.  Right now, it's pretty limited to being used in conjunction with
memory reclaim called from kswapd.  Seems like something we ought to add
to the TODO list before it escapes from staging/.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/