linux-kernel - Re: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317657968.20367.35.camel@twins>
Date:	Mon, 03 Oct 2011 18:06:07 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ian Campbell <Ian.Campbell@...rix.com>
Cc:	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] stop_machine: fixup cut'n'paste error in stopped thread
 name

On Mon, 2011-10-03 at 13:01 +0100, Ian Campbell wrote:
> Noticed this while poking around. Seems like the code was lifted a bit
> more thoroughly from the migration thread mgmt code than the author of
> the preceding comment intended...
> 
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> 
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -312,7 +312,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
>  		p = kthread_create_on_node(cpu_stopper_thread,
>  					   stopper,
>  					   cpu_to_node(cpu),
> -					   "migration/%d", cpu);
> +					   "stopper/%d", cpu);
>  		if (IS_ERR(p))
>  			return notifier_from_errno(PTR_ERR(p));
>  		get_task_struct(p);
> 

IIRC it was because userspace already knew about the migration thread
and we didn't want to confuse things further. But yeah, its not
particularly important.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/