linux-kernel - Re: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init

Open Source and information security mailing list archives

Message-ID: <20111003184642.GH6324@atomide.com>
Date:	Mon, 3 Oct 2011 11:46:42 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Felipe Balbi <balbi@...com>, Bjarne Steinsbo <bsteinsbo@...il.com>
Cc:	Russell King <linux@....linux.org.uk>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, Axel Lin <axel.lin@...il.com>,
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] usb: musb: OMAP4430: Remove a redundant
 omap4430_phy_init call in usb_musb_init

* Tony Lindgren <tony@...mide.com> [110930 10:28]:
> * Felipe Balbi <balbi@...com> [110928 23:35]:
> > On Tue, Sep 20, 2011 at 04:50:29PM +0800, Axel Lin wrote:
> > > Current code calls omap4430_phy_init() twice in usb_musb_init().
> > > Calling omap4430_phy_init() once is enough.
> > > This patch removes the first omap4430_phy_init() call, which using an
> > > uninitialized pointer as parameter.
> > > 
> > > This patch elimates below build warning:
> > > arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
> > > arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
> > > 
> > > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > 
> > Acked-by: Felipe Balbi <balbi@...com>
> 
> Thanks, applying into fixes.

FYI, I'll update this patch to have also Bjarne's SOB to
this patch because of the earlier reference. Will still
use Axel's patch as it shows the compile warning.

Regards,

Tony

> Tony
> 
> > 
> > > ---
> > >  arch/arm/mach-omap2/usb-musb.c |    3 ---
> > >  1 files changed, 0 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > > index a65145b..19e4dac 100644
> > > --- a/arch/arm/mach-omap2/usb-musb.c
> > > +++ b/arch/arm/mach-omap2/usb-musb.c
> > > @@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> > >  	musb_plat.mode = board_data->mode;
> > >  	musb_plat.extvbus = board_data->extvbus;
> > >  
> > > -	if (cpu_is_omap44xx())
> > > -		omap4430_phy_init(dev);
> > > -
> > >  	if (cpu_is_omap3517() || cpu_is_omap3505()) {
> > >  		oh_name = "am35x_otg_hs";
> > >  		name = "musb-am35x";
> > > -- 
> > > 1.7.4.1
> > > 
> > > 
> > > 
> > 
> > -- 
> > balbi
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives