linux-kernel - Re: [patch 00/10] memcg naturalization -rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111003161149.bc458294.akpm00@gmail.com>
Date:	Mon, 3 Oct 2011 16:11:49 -0700
From:	Andrew Morton <akpm00@...il.com>
To:	Johannes Weiner <jweiner@...hat.com>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Balbir Singh <bsingharora@...il.com>,
	Ying Han <yinghan@...gle.com>,
	Greg Thelen <gthelen@...gle.com>,
	Michel Lespinasse <walken@...gle.com>,
	Rik van Riel <riel@...hat.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 00/10] memcg naturalization -rc4

On Thu, 29 Sep 2011 23:00:54 +0200
Johannes Weiner <jweiner@...hat.com> wrote:

> this is the fourth revision of the memory cgroup naturalization
> series.

The patchset removes 20 lines from include/linux/*.h and removes
exactly zero lines from mm/*.c.  Freaky.

If we were ever brave/stupid emough to make
CONFIG_CGROUP_MEM_RES_CTLR=y unconditional, how much could we simplify
mm/?

We are adding bits of overhead to the  CONFIG_CGROUP_MEM_RES_CTLR=n case
all over the place.  This patchset actually decreases the size of allnoconfig
mm/built-in.o by 1/700th.

A "struct mem_cgroup" sometimes gets called "mem", sometimes "memcg",
sometimes "mem_cont".  Any more candidates?  Is there any logic to
this?


Anyway...  it all looks pretty sensible to me, but the timing (at
-rc8!) is terrible.  Please keep this material maintained for -rc1, OK?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/