linux-kernel - Re: [BUGFIX] cgroup: create a workqueue for cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111003141911.b4ee7bca.nishimura@mxp.nes.nec.co.jp>
Date:	Mon, 3 Oct 2011 14:19:11 +0900
From:	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
To:	Andrew Morton <akpm00@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	container ML <containers@...ts.linux-foundation.org>,
	Paul Menage <paul@...lmenage.org>,
	Li Zefan <lizf@...fujitsu.com>, Ingo Molnar <mingo@...e.hu>,
	Miao Xie <miaox@...fujitsu.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Tejun Heo <htejun@...il.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Subject: Re: [BUGFIX] cgroup: create a workqueue for cgroup

On Mon, 3 Oct 2011 09:22:44 +0900
Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:

> On Fri, 30 Sep 2011 15:30:49 -0700
> Andrew Morton <akpm00@...il.com> wrote:
> 
> > On Fri, 30 Sep 2011 16:54:52 +0900
> > Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> > 
> > > In commit:f90d4118, cpuset_wq, a separate workqueue for cpuset, was introduced
> > > to avoid a dead lock against cgroup_mutex between async_rebuild_sched_domains()
> > > and cgroup_tasks_write().
> > > 
> > > But check_for_release() has a similar problem:
> > > 
> > >   check_for_release()
> > >     schedule_work(release_agent_work)
> > >       cgroup_release_agent()
> > >         mutex_lock(&cgroup_mutex)
> > > 
> > > And I actually see a lockup which seems to be caused by this problem
> > > on 2.6.32-131.0.15.el6.x86_64.
> > 
> > Are you sure the bug is still present in current kernels?  Perhaps
> > Tejun's workqueue changes magically made it go away.
> > 
> Not yet, but I'll check it.
> 
As you said, I cannot repricate this issue on 3.1-rc8. But I've verified
it happens on 2.6.32.46 and this patch fixes it, so I think this patch is
necessary for stable at least.

Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/