linux-kernel - Re: [PATCH 1/2] udf : enable error print in udf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317620365.1804.7.camel@Joe-Laptop>
Date:	Sun, 02 Oct 2011 22:39:25 -0700
From:	Joe Perches <joe@...ches.com>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] udf : enable error print in udf_read_tagged().

On Mon, 2011-10-03 at 13:55 +0900, Namjae Jeon wrote:
> While reading metadata, if a problem occurs,
> Print out only one of the five case.(It also does not show a checksum properly.)
> Because currently it have been disable by undef udf_debug.
> If there is a problem with scratched disc or loader, the user needs to know which error happened.
> And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also.
[]
> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
[]
> @@ -21,7 +23,7 @@
>  #ifdef UDFFS_DEBUG
>  #define udf_debug(f, a...) \
>  do { \
> -	printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
> +	pr_debug("DEBUG %s:%d:%s: ", \
>  		__FILE__, __LINE__, __func__); \
>  	printk(f, ##a); \

This isn't the same.

You should probably just use

#define udf_debug(fmt, ...)						\
	pr_debug("DEBUG %s:%d:%s: " fmt,				\
		 __FILE__, __LINE__, __func__, __VA_ARGS__)

or maybe let dynamic_debug add
__FILE__, __LINE__ and __func__
via the appropriate controls,
so this might be appropriate.

#define udf_debug(fmt, ...)						\
	pr_debug("DEBUG " fmt, __VA_ARGS__)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/