linux-kernel - Re: [RFC][PATCH 0/5] Signal scalability series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317716417.3375.91.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Tue, 04 Oct 2011 09:20:17 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	David Mosberger-Tang <davidm@...uge.net>
Subject: Re: [RFC][PATCH 0/5] Signal scalability series

On Tue, 2011-10-04 at 00:13 +0200, Thomas Gleixner wrote:
> 
> After staring a bit at your patch I think that you need to tackle that
> from a different angle.
> 
> The main nuisance of sighand->siglock is the exit race protection and
> that's why we need to take it for evrything and some more.

Right.

> In order to distangle the posix-(cpu)-timer and other stuffs
> protection from that single lock, you need to introduce "independent"
> locks which basically do the same dance as lock_task_sighand() does
> and have to be taken in the exit() path in a well defined order before
> manipulating task->sighand.

Yeah, I've been trying to avoid changing the tsk->sighand stuff (you'll
notice that lock_task_sighand() still works as before in this patch
series) because when I've attempted it before it has always resulted in
much more complicated code (and coming from me, that's saying
something!).

> That way you still cover the exit races, but you can break up the
> locking for particular subsystems w/o the need of (much) nesting.

Yeah, that approach seems interesting. I'll have a look at that, thanks!

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/