linux-kernel - Re: [PATCH 16/26] ARM: pxa: CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMPhdO96WwmPVqVpM2Vpef3wSgfHEf-0tK5VewXn-EGMns2ubA@mail.gmail.com>
Date:	Tue, 4 Oct 2011 08:59:56 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Jason Chagas <jason.chagas@...vell.com>,
	linux-kernel@...r.kernel.org,
	Haojian Zhuang <haojian.zhuang@...vell.com>
Subject: Re: [PATCH 16/26] ARM: pxa: CPU_PJ4 requires IWMMXT

> 8<-----
> Subject: [PATCH] ARM: pxa: CPU_PJ4 requires IWMMXT
>
> The PJ4 based pxa95x cpus all have iwmmxt and there is no way to
> build that code conditionally, so better not ask the user
> in that configuration, in order to prevent broken builds.

I think this is true for other xscale CPUs as well, so either we make
them unconditionally all at once, or we still leave an option here.

It actually looks quite odd to me that CPU_PJ4 is made special here,
what're the real broken builds errors?

>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 5ebc5d9..8d66c32 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1071,9 +1071,10 @@ config ARM_TIMER_SP804
>  source arch/arm/mm/Kconfig
>
>  config IWMMXT
> -       bool "Enable iWMMXt support"
> +       bool "Enable iWMMXt support" if !CPU_PJ4
>        depends on CPU_XSCALE || CPU_XSC3 || CPU_MOHAWK || CPU_PJ4
>        default y if PXA27x || PXA3xx || PXA95x || ARCH_MMP
> +       default y if CPU_PJ4
>        help
>          Enable support for iWMMXt context switching at run time if
>          running on a CPU that supports it.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/