linux-kernel - Re: [V7][PATCH 0/6] x86, nmi: new NMI handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111004150531.GH21506@erda.amd.com>
Date:	Tue, 4 Oct 2011 17:05:31 +0200
From:	Robert Richter <robert.richter@....com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Don Zickus <dzickus@...hat.com>, "x86@...nel.org" <x86@...nel.org>,
	Andi Kleen <andi@...stfloor.org>,
	"ying.huang@...el.com" <ying.huang@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>,
	"avi@...hat.com" <avi@...hat.com>,
	"jeremy@...p.org" <jeremy@...p.org>
Subject: Re: [V7][PATCH 0/6] x86, nmi: new NMI handling routines

On 03.10.11 11:59:08, Peter Zijlstra wrote:
> I didn't need that, I build an allnoconfig (which got me a fail with the
> IBS patches), then an allyesconfig (which got me the earlier fail) and
> this came from my regular config which included the ipmi crap because
> Ingo hit this same fail earlier (-v5 or so) and everybody forgot to tell
> you :/

A change like the one below should fix the IBS build breakage (for
perf, x86: Implement IBS initialization).

-Robert


commit b670049b76a233599ebf64aff16cb8735fe6dc70
Author: Robert Richter <robert.richter@....com>
Date:   Tue Oct 4 16:51:54 2011 +0200

    perf, x86: Fix allnoconfig build error for ibs
    
     arch/x86/kernel/cpu/perf_event_amd_ibs.c: In function ‘get_eilvt’:
     arch/x86/kernel/cpu/perf_event_amd_ibs.c:90: error: implicit declaration of function ‘setup_APIC_eilvt’
    
    Signed-off-by: Robert Richter <robert.richter@....com>

diff --git a/arch/x86/kernel/cpu/perf_event_amd_ibs.c b/arch/x86/kernel/cpu/perf_event_amd_ibs.c
index 1ae5154..cca9e0c 100644
--- a/arch/x86/kernel/cpu/perf_event_amd_ibs.c
+++ b/arch/x86/kernel/cpu/perf_event_amd_ibs.c
@@ -9,6 +9,7 @@
 #include <linux/perf_event.h>
 #include <linux/module.h>
 #include <linux/pci.h>
+#include <asm/apic.h>
 
 static u32 ibs_caps;
 


-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/