linux-kernel - Re: linux-next: build failure after merge of the moduleh tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 04 Oct 2011 16:24:40 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michael Hennerich <michael.hennerich@...log.com>,
	Greg KH <greg@...ah.com>
Subject: Re: linux-next: build failure after merge of the moduleh tree

On 10/04/11 08:21, Stephen Rothwell wrote:
> Hi Paul,
> 
> After merging the moduleh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/staging/iio/adc/ad7746.c:345:8: error: 'S_IWUSR' undeclared here (not in a function)
> drivers/staging/iio/adc/ad7746.c:436:8: error: 'S_IRUGO' undeclared here (not in a function)
> drivers/staging/iio/adc/ad7746.c:681:19: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/staging/iio/adc/ad7746.c:778:1: warning: data definition has no type or storage class [enabled by default]
> drivers/staging/iio/adc/ad7746.c:778:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int]
> drivers/staging/iio/adc/ad7746.c:778:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/staging/iio/adc/ad7746.c:799:15: error: expected declaration specifiers or '...' before string constant
> drivers/staging/iio/adc/ad7746.c:800:20: error: expected declaration specifiers or '...' before string constant
> drivers/staging/iio/adc/ad7746.c:801:16: error: expected declaration specifiers or '...' before string constant
> 
> Caused by commit 83e416f458d5 ("staging: iio: adc: Replace, rewrite
> ad7745 from scratch") from the staging tree interacting with the module.h
> split.
> 
> I added the following patch:
> 
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Tue, 4 Oct 2011 18:18:28 +1100
> Subject: [PATCH] staging: iio: adc: add includes of module.h and stat.h
> 
> fixes these build problems:
> 
> drivers/staging/iio/adc/ad7746.c:345:8: error: 'S_IWUSR' undeclared here (not in a function)
> drivers/staging/iio/adc/ad7746.c:436:8: error: 'S_IRUGO' undeclared here (not in a function)
> drivers/staging/iio/adc/ad7746.c:681:19: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/staging/iio/adc/ad7746.c:778:1: warning: data definition has no type or storage class [enabled by default]
> drivers/staging/iio/adc/ad7746.c:778:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Wimplicit-int]
> drivers/staging/iio/adc/ad7746.c:778:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/staging/iio/adc/ad7746.c:799:15: error: expected declaration specifiers or '...' before string constant
> drivers/staging/iio/adc/ad7746.c:800:20: error: expected declaration specifiers or '...' before string constant
> drivers/staging/iio/adc/ad7746.c:801:16: error: expected declaration specifiers or '...' before string constant
> 
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
Acked-by: Jonathan Cameron <jic23@....ac.uk>

> ---
>  drivers/staging/iio/adc/ad7746.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7746.c b/drivers/staging/iio/adc/ad7746.c
> index 0b251ad..3fe0c17 100644
> --- a/drivers/staging/iio/adc/ad7746.c
> +++ b/drivers/staging/iio/adc/ad7746.c
> @@ -13,6 +13,8 @@
>  #include <linux/sysfs.h>
>  #include <linux/i2c.h>
>  #include <linux/delay.h>
> +#include <linux/module.h>
> +#include <linux/stat.h>
>  
>  #include "../iio.h"
>  #include "../sysfs.h"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/