linux-kernel - Re: [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111004182615.GA16224@suse.de>
Date:	Tue, 4 Oct 2011 11:26:15 -0700
From:	Greg KH <gregkh@...e.de>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	quilt-dev <quilt-dev@...gnu.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	John Kacur <jkacur@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

On Tue, Oct 04, 2011 at 02:15:46PM -0400, Steven Rostedt wrote:
> On Tue, 2011-10-04 at 11:02 -0700, Greg KH wrote:
> > Now if only someone can get quilt working properly for git's "split"
> >  subject: lines, I would be very happy...
> 
> What issues do you have? I use quilt to send git patches all the time.

The other way around, I import git patches into quilt for the stable
series, and then when sending emails out, quilt messes up the subject
lines because it was split across two lines.

> What are git's "split" subject: lines?

Do the following:
 $ git show --pretty=email 21d17dd2a377ba894f26989915eb3c6e427a3656

and look at how the Subject line is formatted:
	Subject: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and
	 WM8753_RADC

Which is legal for email subject lines.  But quilt can't handle this and
ends up thinking the data after the Subject: line is part of the patch
text body and messes stuff up when doing 'quilt mail' later.

So I have to remember to edit the subject: lines all the time, and
cringe when I forget.

Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
line as a valid email address name, but I've been living with that one
for years...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/