linux-kernel - Re: [PATCH 00/11] IO-less dirty throttling v12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2ipo34gfa.fsf@firstfloor.org>
Date:	Wed, 05 Oct 2011 08:16:41 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	linux-fsdevel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@....de>,
	Dave Chinner <david@...morbit.com>,
	Greg Thelen <gthelen@...gle.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Andrea Righi <arighi@...eler.com>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/11] IO-less dirty throttling v12

Vivek Goyal <vgoyal@...hat.com> writes:
>
> Will it make sense to break down this work in two patch series. First
> push IO less balance dirty pages and then all the complicated pieces
> of ratelimits.

I would be wary against too much refactoring of well tested patchkits.
I've seen too many cases where this can add nasty and subtle bugs,
given that our unit test coverage is usually relatively poor.

For example the infamous "absolute path names became twice as slow" 
bug was very likely introduced in such a refactoring of a large VFS
patchkit.

While it's generally good to make things easier for reviewers too much
of a good thing can be quite bad.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/