linux-kernel - Re: [PATCH v2 8/9] KVM, VMX: Add support for guest/host-only profiling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111005152954.GL30105@redhat.com>
Date:	Wed, 5 Oct 2011 17:29:54 +0200
From:	Gleb Natapov <gleb@...hat.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	linux-kernel@...r.kernel.org, avi@...hat.com, kvm@...r.kernel.org,
	joerg.roedel@....com, mingo@...e.hu
Subject: Re: [PATCH v2 8/9] KVM, VMX: Add support for guest/host-only
 profiling

On Wed, Oct 05, 2011 at 04:19:39PM +0200, Peter Zijlstra wrote:
> On Wed, 2011-10-05 at 14:01 +0200, Gleb Natapov wrote:
> > +static void atomic_switch_perf_msrs(struct vcpu_vmx *vmx)
> > +{
> > +       int i, nr_msrs;
> > +       struct perf_guest_switch_msr *msrs;
> > +
> > +       msrs = perf_guest_get_msrs(&nr_msrs);
> > +
> > +       if (!msrs)
> > +               return;
> > +
> > +       for (i = 0; i < nr_msrs; i++)
> > +               if (msrs[i].host == msrs[i].guest)
> > +                       clear_atomic_switch_msr(vmx, msrs[i].msr);
> > +               else
> > +                       add_atomic_switch_msr(vmx, msrs[i].msr, msrs[i].guest,
> > +                                       msrs[i].host);
> > +} 
> 
> I don't think this will actually compile with PERF_EVENTS=n due to
> struct perf_guest_switch_msr not being defined.
Oops you are right. Turns out it is not enough to remove PERF_EVENTS
from .config to disable it. It re-appears after "make oldconfig". Should
I send incremental patch to fix that?

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/