linux-kernel - Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111005201244.GA13027@suse.de>
Date:	Wed, 5 Oct 2011 13:12:44 -0700
From:	Greg KH <gregkh@...e.de>
To:	Andreas Gruenbacher <andreas.gruenbacher@...il.com>
Cc:	quilt-dev@...gnu.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, John Kacur <jkacur@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

On Wed, Oct 05, 2011 at 01:21:07PM +0200, Andreas Gruenbacher wrote:
> On Wed, 2011-10-05 at 10:23 +0200, Andreas Gruenbacher wrote:
> > On Tue, 2011-10-04 at 23:53 -0700, Greg KH wrote:
> > > Yes, quoting is the correct thing to do, but that does not usually
> > > happen in "Signed-off-by:" lines in kernel patches.
> > > 
> > > Actually, I think this is even a problem when the name is quoted
> > > properly, I've had to fix that up in patches by hand.
> > 
> > Yes, proper quoting currently isn't enough.
> >
> > > And yes, this is a problem, I run into at least 1-2 patches per stable
> > > kernel release with this issue.  I looked into fixing it and somehow the
> > > email parsing logic was wierd and I couldn't figure out how to resolve
> > > it.
> > 
> > Okay, I'll have another look ...
> 
> I've tried to address this as follows now:
> 
> commit f3e7822028616014f933b99d05f42fc028f8d12c
> Author: Andreas Gruenbacher <agruen@...bit.com>
> Date:   Wed Oct 5 12:57:48 2011 +0200
> 
>     quilt mail: Allow commas in Signed-off-by and Acked-by lines
>     
>     The standard quilt_mail_patch_filter() in quilt mail tries to extract email
>     addresses from Signed-off-by and Acked-by lines.  It adds Cc headers with those
>     addresses.
>     
>     Signed-off-by and Acked-by lines sometimes contain commas as part of the
>     address.  When put in recipient headers (To, Cc, Bcc), the commas are
>     interpreted as separators, which breaks things.
>     
>     Try to recognize this case and add the appropriate quotes.  For example, the
>     email address in ``Signed-off-by: Gruenbacher, Andreas <agruen@...bit.com>'' is
>     now extracted as ``"Gruenbacher, Andreas" <agruen@...bit.com>''.
>     
>     Note that quilt_mail_patch_filter() can be overridden in .quiltrc; you may need
>     to update your .quiltrc.
> 
> commit c6750845136ff21eb13bc99ec7a6e1689100a13a
> Author: Andreas Gruenbacher <agruen@...bit.com>
> Date:   Wed Oct 5 12:08:05 2011 +0200
> 
>     quilt mail: Support double quoted special characters in email adresses
>     
>     Addresses like "Gruenbacher, Andreas" <agruen@...bit.com> will work now.
> 
> 
> Please give it a shot.

Thanks for doing this.  I can't seem to find the git tree for quilt at
the moment, any pointers to where it is?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/