linux-kernel - Re: [PATCH 1/2 v3] udf : enable error print in udf_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317853198.3095.19.camel@Joe-Laptop>
Date:	Wed, 05 Oct 2011 15:19:58 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Namjae Jeon <linkinjeon@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 v3] udf : enable error print in udf_read_tagged().

On Thu, 2011-10-06 at 00:08 +0200, Jan Kara wrote:
> Hello,
> 
> On Mon 03-10-11 22:53:57, Namjae Jeon wrote:
> > While reading metadata, if a problem occurs, Print out only one of the
> > five case.(It also does not show a checksum properly.) Because currently
> > it have been disable by undef udf_debug.  If there is a problem with
> > scratched disc or loader, the user needs to know which error happened.
> > And I use pr_fmt instead of printk by joe's suggestion. I try to modify
> > totally it to pr_fmt also.

>   Thanks for the patch. I'm willing to take the patch since it's an
> improvement but what would be even nicer is to have error reporting like in
> ext3 / ext4. We would have functions udf_info, udf_warn, udf_err which
> also print sb->s_id with each error so that user can better identify on
> which filesystem error happened.

Modifying the follow-on patch I sent would be pretty trivial.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/