linux-kernel - Re: [RFC] drivercore: Add helper macro for platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANqRtoTWach63ZgfLOs5c3UKoPo2F-kwe44OMpRqYvN_hmg+PA@mail.gmail.com>
Date:	Wed, 5 Oct 2011 17:12:53 +0900
From:	Magnus Damm <magnus.damm@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	greg@...ah.com, Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] drivercore: Add helper macro for platform_driver boilerplate

On Wed, Oct 5, 2011 at 8:26 AM, Grant Likely <grant.likely@...retlab.ca> wrote:
> For simple modules that contain a single platform_driver without any
> additional setup code then ends up being a block of duplicated
> boilerplate.  This patch adds a new macro, module_platform_driver(),
> which replaces the module_init()/module_exit() registrations with
> template functions.
>
> This patch also converts all the relevant spi drivers to use the new
> macro.  There are a lot of drivers in the tree that are using this
> pattern and could be converted.
>
> It also fixes up some incorrect section annotations where I found
> them.
>
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> ---
>
> I think this is useful, and I like the diffstat that it produces.
> What does everyone else think of this approach?  I can do versions for
> i2c_drivers and spi_drivers too.

This is excellent, I've been wanting something like this forever!

Now the only thing left is dd.c not ignoring the ->remove() return
value - then I finally could sleep at night. I've seen that someone
has been poking around there and fixing the return values, nice to
see.

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/