linux-kernel - Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317803067.1623.4.camel@schurl.linbit>
Date:	Wed, 05 Oct 2011 10:23:49 +0200
From:	Andreas Gruenbacher <andreas.gruenbacher@...il.com>
To:	Greg KH <gregkh@...e.de>
Cc:	quilt-dev@...gnu.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, John Kacur <jkacur@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

On Tue, 2011-10-04 at 23:53 -0700, Greg KH wrote:
> "now" meaning which version of quilt?  I still see this on 0.48 if that
> matters.

In the repository (master branch).

> > > > Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
> > > > line as a valid email address name, but I've been living with that one
> > > > for years...
> > 
> > That's not even valid in email addresses.  The proper way would be to
> > double-quote the "display name" which probably contains the comma, but
> > then quilt's edmail script still won't understand it.  Is this a real
> > problem?
> 
> Yes, quoting is the correct thing to do, but that does not usually
> happen in "Signed-off-by:" lines in kernel patches.
> 
> Actually, I think this is even a problem when the name is quoted
> properly, I've had to fix that up in patches by hand.

Yes, proper quoting currently isn't enough.

> And yes, this is a problem, I run into at least 1-2 patches per stable
> kernel release with this issue.  I looked into fixing it and somehow the
> email parsing logic was wierd and I couldn't figure out how to resolve
> it.

Okay, I'll have another look ...

Andreas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/