linux-kernel - Re: [PATCHv5 2/4] usb: gadget: replace "is_dualspeed" with "max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111006092708.GC1714@legolas.emea.dhcp.ti.com>
Date:	Thu, 6 Oct 2011 12:27:10 +0300
From:	Felipe Balbi <balbi@...com>
To:	Michal Nazarewicz <mnazarewicz@...gle.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Yang Rui Rui <ruirui.r.yang@...to.com>,
	Dave Young <hidave.darkstar@...il.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv5 2/4] usb: gadget: replace "is_dualspeed" with
 "max_speed"

On Fri, Sep 09, 2011 at 04:14:21PM +0200, Michal Nazarewicz wrote:
> On Fri, 26 Aug 2011 15:18:35 +0200, Michal Nazarewicz
> <mnazarewicz@...gle.com> wrote:
> >This commit replaces usb_gadget's is_dualspeed field with
> >a max_speed field.
> >---
> >
> >I was unable to figure out how to create a symlink in
> >non-race-condition way so for now I've created both speed and
> >current_speed attributes.  This needs to get fixed before getting
> >merged.
> >
> >I would even consider just removing speed since udc-core got merged
> >only in 3.1, so maybe it won't be such a big issue?
> 
> I've dug a bit deeper and could not find *any* way of creating the
> speed -> current_speed symlink.  sysfs_create_link() requires target
> to be an kobject and as far as I can see attributes don't have one.
> 
> So I see the following possibilities:
> 
> 1. Leave speed only (as Felipe noticed, this may be confusing for
>    users since there will be "speed" and "maximum_speed").
> 2. Rename it to current_speed without transition period (udc-core is
>    young so maybe no one will notice, but that won't be very nice).

let's use current_speed without the grace period.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)