linux-kernel - Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317916878.1823.2.camel@Joe-Laptop>
Date:	Thu, 06 Oct 2011 09:01:18 -0700
From:	Joe Perches <joe@...ches.com>
To:	Fabrice Jouhaud <yargil@...e.fr>
Cc:	linux-ext4@...r.kernel.org, tytso@....edu,
	adilger.kernel@...ger.ca, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs

On Thu, 2011-10-06 at 17:51 +0200, Fabrice Jouhaud wrote:
> From: Yargil <yargil@...e.fr>

It would be better to use your full name on the "From: " line

> Regression from commit dd68314ccf3fb918c1fb6471817edbc60ece4b52
> The problem come from the test of the return value of proc_mkdir
> that is always false without procfs and abort the init of ext4.
> 
> Signed-off-by: Fabrice Jouhaud <yargil@...e.fr>
> ---
>  fs/ext4/super.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 44d0c8d..9b51b17 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4985,8 +4985,10 @@ static int __init ext4_init_fs(void)
>  	if (!ext4_kset)
>  		goto out6;
>  	ext4_proc_root = proc_mkdir("fs/ext4", NULL);
> +#ifdef CONFIG_PROC_FS
>  	if (!ext4_proc_root)
>  		goto out5;
> +#endif

It would make more sense as:

+#ifdef CONFIG_PROC_FS
	ext4_proc_root = proc_mkdir("fs/ext4", NULL);
  	if (!ext4_proc_root)
 		goto out5;
+#endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/