linux-kernel - Re: [RFC] drivercore: Add helper macro for platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOZdJXUF1tr37AuYLq6d+MP8ahWn7M1EE0jX9-6zYR0A3sSD4Q@mail.gmail.com>
Date:	Thu, 6 Oct 2011 18:35:28 +0000
From:	Tabi Timur-B04825 <B04825@...escale.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	"greg@...ah.com" <greg@...ah.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] drivercore: Add helper macro for platform_driver
 boilerplate

On Tue, Oct 4, 2011 at 6:26 PM, Grant Likely <grant.likely@...retlab.ca> wrote:

> diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c
> index ae2cd1c..7795d4d 100644
> --- a/drivers/spi/spi-coldfire-qspi.c
> +++ b/drivers/spi/spi-coldfire-qspi.c
> @@ -621,20 +621,10 @@ static struct platform_driver mcfqspi_driver = {
>        .driver.name    = DRIVER_NAME,
>        .driver.owner   = THIS_MODULE,
>        .driver.pm      = MCFQSPI_DEV_PM_OPS,
> +       .probe          = mcfqspi_probe,
>        .remove         = __devexit_p(mcfqspi_remove),
>  };

So I had no idea that platform_driver_probe() existed.  It looks like
I function I should be using for SOC devices.  But I'm confused by one
thing.  That function says it's for non-hotpluggable devices.  I don't
see in module_platform_driver() where you honor that restriction.  It
looks like you're replacing the non-hotpluggable probe with a
hotpluggable probe.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/