linux-kernel - Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E1RBswD-0003hi-Eo@bigred.inka.de>
Date:	Thu, 06 Oct 2011 20:44:57 +0200
From:	Olaf Titz <olaf@...red.inka.de>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs

> It would make more sense as:
>
> +#ifdef CONFIG_PROC_FS
> 	ext4_proc_root = proc_mkdir("fs/ext4", NULL);
>   	if (!ext4_proc_root)
>  		goto out5;
> +#endif

Looks right, but even more logical would be to guard _all_ usage of
ext4_proc_root (and, consequently, the declaration thereof) in #ifdef
CONFIG_PROC_FS. Now it's at least necessary to always do null checks.

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/