[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111006040656.GA2125@ubuntu.ubuntu-domain>
Date: Thu, 6 Oct 2011 09:36:59 +0530
From: Himanshu Chauhan <hschauhan@...ltrace.org>
To: Guenter Roeck <guenter.roeck@...csson.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kernelnewbies@...nelnewbies.org" <kernelnewbies@...nelnewbies.org>,
lm-sensors@...sensors.org
Subject: Re: [PATCH] hwmon class driver registration with a device number
Hi,
> I can not comment on the merits of your patch. Unless I am missing
> something, which may well be since I only spent a couple of minutes on
> it, other device classes don't seem to provide a similar API, so I don't
> know if or why it would make sense for hwmon. Maybe a driver which wants
> to register a character device interface should do so independently of
> hwmon.
>
The idea here is to sit in the same class directory as of hwmon. Devices
registered with this interface will have "dev" under, for example,
/sys/class/hwmon/hwmon0/dev. To do the same inside the driver will be
a bit more involved than a call.
In my opinion other classes should also have similar interfaces.
> On the technical side, EXPORT_SYMBOL is missing.
>
I will take care of that.
Regards
Himanshu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists