linux-kernel - Re: [PATCH] usb: add new usb gadget for ACM and mass storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111007083856.GB10910@legolas.emea.dhcp.ti.com>
Date:	Fri, 7 Oct 2011 11:38:58 +0300
From:	Felipe Balbi <balbi@...com>
To:	Klaus Schwarzkopf <schwarzkopf@...sortherm.de>
Cc:	balbi@...com, gregkh@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: add new usb gadget for ACM and mass storage

Hi,

On Fri, Oct 07, 2011 at 10:23:10AM +0200, Klaus Schwarzkopf wrote:
> Hi,
> 
> thanks for your comments. See my patch v2.
> 
> Am 06.10.2011 14:08, schrieb Felipe Balbi:
> 
> >
> >>+#define CDC_VENDOR_NUM	0x1d6b	/* Linux Foundation */
> >>+#define CDC_PRODUCT_NUM	0x0106	/* CDC Composite: ACM + MS*/
> >
> >did you ask Greg for this ?
> >
> 
> Greg wrote:
> 
> I'll do that when I accept the patch for merging into the kernel, and
> not before.

ok.

> >>+/*-------------------------------------------------------------------------*/
> >>+
> >>+/*
> >>+ * Kbuild is not very cooperative with respect to linking separately
> >>+ * compiled library objects into one module.  So for now we won't use
> >>+ * separate compilation ... ensuring init/exit sections work to shrink
> >>+ * the runtime footprint, and giving us at least some parts of what
> >>+ * a "gcc --combine ... part1.c part2.c part3.c ... " build would.
> >>+ */
> >>+
> >>+#include "composite.c"
> >>+#include "usbstring.c"
> >>+#include "config.c"
> >>+#include "epautoconf.c"
> >>+#include "u_serial.c"
> >>+#include "f_acm.c"
> >>+#include "f_mass_storage.c"
> >>+
> >>+/*-------------------------------------------------------------------------*/
> >>+
> >>+static struct usb_device_descriptor device_desc = {
> >>+	.bLength =		sizeof device_desc,
> >>+	.bDescriptorType =	USB_DT_DEVICE,
> >>+
> >>+	.bcdUSB =		cpu_to_le16(0x0200),
> >>+
> >>+	.bDeviceClass =		USB_CLASS_COMM,
> >>+	.bDeviceSubClass =	0,
> >>+	.bDeviceProtocol =	0,
> >>+	/* .bMaxPacketSize0 = f(hardware) */
> >>+
> >>+	/* Vendor and product id can be overridden by module parameters.  */
> >>+	.idVendor =		cpu_to_le16(CDC_VENDOR_NUM),
> >>+	.idProduct =		cpu_to_le16(CDC_PRODUCT_NUM),
> >>+	/* .bcdDevice = f(hardware) */
> >>+	/* .iManufacturer = DYNAMIC */
> >>+	/* .iProduct = DYNAMIC */
> >>+	/* NO SERIAL NUMBER */
> >
> >why not ? If someone wants to make a product out of this, they will need
> >a serial number.
> >
> 
> If an developer want a serial number, he can change this.

ok.

> >>diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> >>index dd1571d..f623f3d 100644
> >>--- a/include/linux/usb/gadget.h
> >>+++ b/include/linux/usb/gadget.h
> >>@@ -15,6 +15,7 @@
> >>  #ifndef __LINUX_USB_GADGET_H
> >>  #define __LINUX_USB_GADGET_H
> >>
> >>+#include<linux/device.h>
> >
> >this is not part of $SUBJECT
> >
> 
> changed git message

not enough. adding another header is not part of this patch. You need to
let us know why you need this new header there and you need add proper
spacing there.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)