linux-kernel - RE: [Patch 5/11] Regulator: DA9052 regulator support v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C3AE124F08223B42BC95AEB82F0F6CED021908@KCHJEXMB01.kpit.com>
Date:	Fri, 7 Oct 2011 10:20:33 +0000
From:	Ashish Jangam <Ashish.Jangam@...tcummins.com>
To:	"Ying-Chun Liu (PaulLiu)" <paul.liu@...aro.org>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Dajun <dajun.chen@...semi.com>,
	"linaro-dev@...ts.linaro.org" <linaro-dev@...ts.linaro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>
Subject: RE: [Patch 5/11] Regulator: DA9052 regulator support v3

> -----Original Message-----
> From: Ying-Chun Liu (PaulLiu) [mailto:paul.liu@...aro.org]
> Sent: Friday, October 07, 2011 2:54 PM
> To: Ashish Jangam
> Cc: Mark Brown; Dajun; linaro-dev@...ts.linaro.org; linux-
> kernel@...r.kernel.org; lrg@...mlogic.co.uk
> Subject: Re: [Patch 5/11] Regulator: DA9052 regulator support v3
> 
> (2011年07月06日 18:36), ashishj3 wrote:
> > +static int __devinit da9052_regulator_probe(struct platform_device *pdev)
> > +{
> > +	struct da9052_regulator *regulator;
> > +	struct da9052 *da9052;
> > +	struct da9052_pdata *pdata;
> > +	int ret;
> > +
> > +	regulator = kzalloc(sizeof(struct da9052_regulator), GFP_KERNEL);
> > +	if (!regulator)
> > +		return -ENOMEM;
> > +
> > +	da9052 = dev_get_drvdata(pdev->dev.parent);
> > +	pdata = da9052->dev->platform_data;
> > +
> > +	regulator->info = find_regulator_info(pdev->id);
> > +	if (regulator->info == NULL) {
> > +		dev_err(&pdev->dev, "invalid regulator ID specified\n");
> > +		ret = -EINVAL;
> > +		goto err;
> > +	}
> > +
> > +	regulator->rdev = regulator_register(&regulator->info->reg_desc,
> > +					     &pdev->dev,
> > +					     pdata->regulators[pdev->id],
> > +					     regulator);
> > +	if (IS_ERR(regulator->rdev)) {
> > +		dev_err(&pdev->dev, "failed to register regulator %s\n",
> > +			regulator->info->reg_desc.name);
> > +		ret = PTR_ERR(regulator->rdev);
> > +		goto err;
> > +	}
> > +
> > +	platform_set_drvdata(pdev, regulator);
> > +
> > +	return 0;
> > +err:
> > +	kfree(regulator);
> > +	return ret;
> > +}
> 
> Hi Ashish,
> 
> It seems to me that in this function, regulator->da9052 isn't initialized.
>
Today I'm going to post regulator patch for DA9052 and DA9053 that has got fixes for this and few more bugs.
This patch is thoroughly tested for DA9052 and DA9053. 
> Regards,
> Paul