linux-kernel - Re: [PATCH 04/12] perf_events: sync branch stack sampling with X86 precise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBTWU8AO_t4CNRbQVdGU3OnkAT9W=Ngj+x4dL5hpAHz=2g@mail.gmail.com>
Date:	Fri, 7 Oct 2011 12:34:50 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, acme@...hat.com,
	ming.m.lin@...el.com, andi@...stfloor.org, robert.richter@....com,
	ravitillo@....gov
Subject: Re: [PATCH 04/12] perf_events: sync branch stack sampling with X86 precise_sampling

On Thu, Oct 6, 2011 at 7:25 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Thu, 2011-10-06 at 16:49 +0200, Stephane Eranian wrote:
>>
>> On Intel X86 PERF_SAMPLE_BRANCH_STACK is implemented using LBR,
>> therefore both features must be coordinated as they may not
>> configure LBR the same way.
>
> Differently, you mean? Both wanting the same configuration seems fine.
>
No, I meant you can allow LBR + precise_sampling>1 ONLY when
users set LBR to record ALL branches and at the same priv levels. In
other words,
you're exposing the LBR content used by the fixup code.

One could argue, that if LBR is set to filter certain branches, it may
also be okay,
it's just that you won't necessarily get the same number of successful
fixups. The
samples are tagged when fixups were successful, so that may also be an viable
option. Best effort given the content of the LBR. Depending on the
code, that might
be slightly better than dropping to precise_sampling=1 (no fixups).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/