linux-kernel - Re: [PATCH 05/26] dynamic_debug: pr_err() call should not depend upon verbosity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1318022466.11045.18.camel@Joe-Laptop>
Date:	Fri, 07 Oct 2011 14:21:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	jim.cromie@...il.com
Cc:	jbaron@...hat.com, greg@...ah.com, bart.vanassche@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/26] dynamic_debug: pr_err() call should not depend
 upon verbosity

On Fri, 2011-10-07 at 14:33 -0600, jim.cromie@...il.com wrote:
> Also convert to pr_err(), which supplies __func__ via pr_fmt.

Just a note on the changelog.
The original code already uses pr_err.

> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -334,8 +334,7 @@ static int ddebug_parse_query(char *words[], int nwords,
>  				query->last_lineno = query->first_lineno;
>  			}
>  		} else {
> -			if (verbose)
> -				pr_err("unknown keyword \"%s\"\n", words[i]);
> +			pr_err("unknown keyword \"%s\"\n", words[i]);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/