linux-kernel - Re: [PATCH 1/5] drivercore: add new error value for deferred probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACxGe6uOmrLwJSPw4JHuOmt5B2wsukdDgVUr01pryq5Z9BFadw@mail.gmail.com>
Date:	Fri, 7 Oct 2011 16:12:45 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Greg KH <greg@...ah.com>
Cc:	"G, Manjunath Kondaiah" <manjugk@...com>,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dilan Lee <dilee@...dia.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Manjunath GKondaiah <manjunath.gkondaiah@...aro.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/5] drivercore: add new error value for deferred probe

On Fri, Oct 7, 2011 at 12:43 AM, Greg KH <greg@...ah.com> wrote:
> On Fri, Oct 07, 2011 at 10:33:06AM +0500, G, Manjunath Kondaiah wrote:
>>
>> Add new error value so that drivers can request deferred probe
>> from drivercore.
>>
>> Signed-off-by: G, Manjunath Kondaiah <manjugk@...com>
>> Reported-by: Grant Likely <grant.likely@...retlab.ca>
>> ---
>> Cc: linux-omap@...r.kernel.org
>> Cc: linux-mmc@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Cc: Grant Likely <grant.likely@...retlab.ca>
>> Cc: Greg Kroah-Hartman <greg@...ah.com>
>> Cc: Dilan Lee <dilee@...dia.com>
>> Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>
>> Cc: Manjunath GKondaiah <manjunath.gkondaiah@...aro.org>
>> Cc: Arnd Bergmann <arnd@...db.de>
>>
>>  include/linux/errno.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/errno.h b/include/linux/errno.h
>> index 4668583..83d8fcf 100644
>> --- a/include/linux/errno.h
>> +++ b/include/linux/errno.h
>> @@ -16,6 +16,7 @@
>>  #define ERESTARTNOHAND       514     /* restart if no handler.. */
>>  #define ENOIOCTLCMD  515     /* No ioctl command */
>>  #define ERESTART_RESTARTBLOCK 516 /* restart by calling sys_restart_syscall */
>> +#define EPROBE_DEFER 517     /* restart probe again after some time */
>
> Can we really do this?

According to Arnd, yes this is okay.

>  Isn't this some user/kernel api here?
>
> What's wrong with just "overloading" on top of an existing error code?
> Surely one of the other 516 types could be used here, right?

overloading makes it really hard to find the users at a later date.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/